Hi Nathan, On Tue, Sep 13, 2022 at 5:55 PM Nathan Huckleberry <[email protected]> wrote: > > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode *mode); > > The mismatched return type breaks forward edge kCFI since the underlying > function definition does not match the function hook definition. > > The return type of imx_tve_connector_mode_valid should be changed from > int to enum drm_mode_status. > > Reported-by: Dan Carpenter <[email protected]> > Link: https://github.com/ClangBuiltLinux/linux/issues/1703 > Cc: [email protected] > Signed-off-by: Nathan Huckleberry <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
