hi -----Original Message----- From: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org> Sent: Thursday, November 3, 2022 12:34 AM To: Allen Chen (陳柏宇) <allen.c...@ite.com.tw> Cc: treapk...@chromium.org; Jau-Chih Tseng (曾昭智) <jau-chih.ts...@ite.com.tw>; Hermes Wu (吳佳宏) <hermes...@ite.com.tw>; Kenneth Hung (洪家倫) <kenneth.h...@ite.com.tw>; andrzej.ha...@intel.com; narmstr...@baylibre.com; robert.f...@linaro.org; laurent.pinch...@ideasonboard.com; jo...@kwiboo.se; jernej.skra...@gmail.com; airl...@linux.ie; dan...@ffwll.ch; robh...@kernel.org; krzysztof.kozlowski...@linaro.org; dri-devel@lists.freedesktop.org; devicet...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
On 02/11/2022 02:54, allen.c...@ite.com.tw wrote: > On 26/10/2022 23:01, allen wrote: >> From: allen chen <allen.c...@ite.com.tw> >> >> Add properties to restrict dp output data-lanes and clock. > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my feedback got > lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all requested > changes or keep discussing them. > > Thank you. > > ==> I am sorry I didn't find the missing advice you said. Could you explain > it again? > > Rob asked - Commit msg should explain reason for breaking users. And where is the reason? I saw only one sentence "Add properties to restrict dp output data-lanes and clock." ==> I will add the commit msg in v7. Thanks for the suggestion. Best regards, Krzysztof
