[PATCH v1 1/2] drm/virtio: Attach and set suggested_x/y properties for the connector

[Vivek Kasireddy]

These properties provide a way to suggest to the userspace the preferred
positions for the outputs. Mutter already uses these properties to
determine the best positions for the outputs.

Cc: Gerd Hoffmann <kra...@redhat.com>
Cc: Dongwon Kim <dongwon....@intel.com>
Signed-off-by: Vivek Kasireddy <vivek.kasire...@intel.com>
---
 drivers/gpu/drm/virtio/virtgpu_display.c |  5 +++++
 drivers/gpu/drm/virtio/virtgpu_vq.c      | 12 ++++++++++++
 2 files changed, 17 insertions(+)

diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c 
b/drivers/gpu/drm/virtio/virtgpu_display.c
index 9ea7611a9e0f..868b0183c6df 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -282,6 +282,10 @@ static int vgdev_output_init(struct virtio_gpu_device 
*vgdev, int index)
        drm_connector_helper_add(connector, &virtio_gpu_conn_helper_funcs);
        if (vgdev->has_edid)
                drm_connector_attach_edid_property(connector);
+       drm_object_attach_property(&connector->base,
+                                  dev->mode_config.suggested_x_property, 0);
+       drm_object_attach_property(&connector->base,
+                                  dev->mode_config.suggested_y_property, 0);
 
        drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL);
        drm_encoder_helper_add(encoder, &virtio_gpu_enc_helper_funcs);
@@ -350,6 +354,7 @@ int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev)
        vgdev->ddev->mode_config.max_height = YRES_MAX;
 
        vgdev->ddev->mode_config.fb_modifiers_not_supported = true;
+       drm_mode_create_suggested_offset_properties(vgdev->ddev);
 
        for (i = 0 ; i < vgdev->num_scanouts; ++i)
                vgdev_output_init(vgdev, i);
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c 
b/drivers/gpu/drm/virtio/virtgpu_vq.c
index 9ff8660b50ad..8e2e512e7c4b 100644
--- a/drivers/gpu/drm/virtio/virtgpu_vq.c
+++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
@@ -638,6 +638,17 @@ virtio_gpu_cmd_resource_attach_backing(struct 
virtio_gpu_device *vgdev,
        virtio_gpu_queue_fenced_ctrl_buffer(vgdev, vbuf, fence);
 }
 
+static void virtio_gpu_update_output_position(struct virtio_gpu_output *output)
+{
+       struct drm_connector *connector = &output->conn;
+       struct drm_device *dev = connector->dev;
+
+       drm_object_property_set_value(&connector->base,
+               dev->mode_config.suggested_x_property, output->info.r.x);
+       drm_object_property_set_value(&connector->base,
+               dev->mode_config.suggested_y_property, output->info.r.y);
+}
+
 static void virtio_gpu_cmd_get_display_info_cb(struct virtio_gpu_device *vgdev,
                                               struct virtio_gpu_vbuffer *vbuf)
 {
@@ -648,6 +659,7 @@ static void virtio_gpu_cmd_get_display_info_cb(struct 
virtio_gpu_device *vgdev,
        spin_lock(&vgdev->display_info_lock);
        for (i = 0; i < vgdev->num_scanouts; i++) {
                vgdev->outputs[i].info = resp->pmodes[i];
+               virtio_gpu_update_output_position(&vgdev->outputs[i]);
                if (resp->pmodes[i].enabled) {
                        DRM_DEBUG("output %d: %dx%d+%d+%d", i,
                                  le32_to_cpu(resp->pmodes[i].r.width),
-- 
2.37.2