On 10.11.22 19:38, Jagan Teki wrote: > HSA/HBP/HFP/HSE mode bits in Exynos DSI host specify a naming > conversion as 'disable mode bit' due to its bit definition, > 0 = Enable and 1 = Disable. > > Fix the naming convention of the mode bits. > > Signed-off-by: Jagan Teki <ja...@amarulasolutions.com> > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index b5305b145ddb..fce7f0a7e4ee 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -75,10 +75,10 @@ > #define DSIM_MAIN_PIX_FORMAT_RGB565 (0x4 << 12) > #define DSIM_SUB_VC (((x) & 0x3) << 16) > #define DSIM_MAIN_VC (((x) & 0x3) << 18) > -#define DSIM_HSA_MODE (1 << 20) > -#define DSIM_HBP_MODE (1 << 21) > -#define DSIM_HFP_MODE (1 << 22) > -#define DSIM_HSE_MODE (1 << 23) > +#define DSIM_HSA_DISABLE (1 << 20) > +#define DSIM_HBP_DISABLE (1 << 21) > +#define DSIM_HFP_DISABLE (1 << 22) > +#define DSIM_HSE_DISABLE (1 << 23) > #define DSIM_AUTO_MODE (1 << 24) > #define DSIM_VIDEO_MODE (1 << 25) > #define DSIM_BURST_MODE (1 << 26) > @@ -804,13 +804,13 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi) > if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_AUTO_VERT) > reg |= DSIM_AUTO_MODE; > if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSE) > - reg |= DSIM_HSE_MODE; > + reg |= DSIM_HSE_DISABLE;
Please add a comment to explain that the DSIM_HSE_DISABLE bit as named in the datasheet actually has inverted logic (set = HSE enabled). > if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HFP) > - reg |= DSIM_HFP_MODE; > + reg |= DSIM_HFP_DISABLE; > if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HBP) > - reg |= DSIM_HBP_MODE; > + reg |= DSIM_HBP_DISABLE; > if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HSA) > - reg |= DSIM_HSA_MODE; > + reg |= DSIM_HSA_DISABLE; > } > > if (dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET)
