Hi Maíra, Thanks for your review!
On Wed, Dec 07, 2022 at 11:26:13AM -0300, Maíra Canal wrote: > On 12/1/22 12:11, Maxime Ripard wrote: > > Accessing a register when running under kunit is a bad idea since our > > device is completely mocked. > > > > Fail the current test if we ever access any of our hardware registers. > > > > Reviewed-by: Javier Martinez Canillas <[email protected]> > > Signed-off-by: Maxime Ripard <[email protected]> > > Reviewed-by: Maíra Canal <[email protected]> > > Just a small nit: I believe that macros with multiple statements should be > enclosed in a do-while block [1], even READ macros. I saw that you enclosed > the WRITE macros on a do-while block, but not the READ macros. This is on purpose: do-while blocks don't return a value, but ({ ... }) blocks do. So we can do a write macros with a do-while, but can't for read since we expect to get a value back. Maxime
signature.asc
Description: PGP signature
