On 12/16/22 05:23, Yi Yang wrote:
> Smatch report warning as follows:
>
> Line 53679: drivers/gpu/drm/amd/display/dc/core/dc_stream.c:402
> dc_stream_set_cursor_position() warn: variable dereferenced before
> check 'stream'
>
> The value of 'dc' has been assigned after check whether 'stream' is
> NULL. Fix it by remove redundant assignment.
>
> Signed-off-by: Yi Yang <yiyan...@huawei.com>
If this didn't blow up until now we might not even need
the NULL check below, but either way this is correct and
Reviewed-by: Harry Wentland <harry.wentl...@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index 20e534f73513..78d31bb875d1 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -408,7 +408,7 @@ bool dc_stream_set_cursor_position(
> struct dc_stream_state *stream,
> const struct dc_cursor_position *position)
> {
> - struct dc *dc = stream->ctx->dc;
> + struct dc *dc;
> bool reset_idle_optimizations = false;
>
> if (NULL == stream) {
