Re: [PATCH v2 01/10] drm/client: Test for connectors before sending hotplug event

[Thomas Zimmermann]

Hi

Am 25.01.23 um 09:30 schrieb Javier Martinez Canillas:

Hello Thomas,

On 1/24/23 14:40, Thomas Zimmermann wrote:

Test for connectors in the client code and remove a similar test
from the generic fbdev emulation. Do nothing if the test fails.
Not having connectors indicates a driver bug.

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
---

Reviewed-by: Javier Martinez Canillas <javi...@redhat.com>

but I've a question below.

  drivers/gpu/drm/drm_client.c        | 5 +++++
  drivers/gpu/drm/drm_fbdev_generic.c | 5 -----
  2 files changed, 5 insertions(+), 5 deletions(-)

[...]

--- a/drivers/gpu/drm/drm_fbdev_generic.c
+++ b/drivers/gpu/drm/drm_fbdev_generic.c
@@ -389,11 +389,6 @@ static int drm_fbdev_client_hotplug(struct drm_client_dev 
*client)
        if (dev->fb_helper)
                return drm_fb_helper_hotplug_event(dev->fb_helper);

-               drm_dbg_kms(dev, "No connectors found, will not create 
framebuffer!\n");
-               return 0;
-       }
-

- if (!dev->mode_config.num_connector) {

What about the following code snippet:

        if (!drm_drv_uses_atomic_modeset(dev))
                drm_helper_disable_unused_functions(dev);

that seems to be something that should be in the core client dev hotplug
as well, since it isn't specific to the fbdev emulation client ?

Best regards
Thomas

That's in the middle of the initial probing code and disables pipeline elements in non-atomic modesetting. TBH I don't dare to move it around. If we ever have other clients, we can attempt the put it into the client.

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

OpenPGP_signature
Description: OpenPGP digital signature