Re: [PATCH v3 16/27] drm/msm/dpu: drop redundant plane dst check from dpu_crtc_atomic_check()

[Abhinav Kumar]

On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote:

The helper drm_atomic_helper_check_plane_state() already checks whether
the scaled and clipped plane falls into the CRTC visible region (and
clears plane_state->visible if it doesn't). Drop the redundant check
from dpu_crtc_atomic_check().

Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>

Reviewed-by: Abhinav Kumar <quic_abhin...@quicinc.com>

---
  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 16 ----------------
  1 file changed, 16 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index bd09bb319a58..73e1a8c69ef0 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -1132,11 +1132,9 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,

const struct drm_plane_state *pstate;

        struct drm_plane *plane;
-       struct drm_display_mode *mode;

int rc = 0; - struct drm_rect crtc_rect = { 0 };

        bool needs_dirtyfb = dpu_crtc_needs_dirtyfb(crtc_state);

if (!crtc_state->enable || !crtc_state->active) {

@@ -1147,7 +1145,6 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,
                return 0;
        }

- mode = &crtc_state->adjusted_mode;

        DRM_DEBUG_ATOMIC("%s: check\n", dpu_crtc->name);

/* force a full mode set if active state changed */

@@ -1157,13 +1154,9 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,
        if (cstate->num_mixers)
                _dpu_crtc_setup_lm_bounds(crtc, crtc_state);

- crtc_rect.x2 = mode->hdisplay;

-       crtc_rect.y2 = mode->vdisplay;
-
        /* FIXME: move this to dpu_plane_atomic_check? */
        drm_atomic_crtc_state_for_each_plane_state(plane, pstate, crtc_state) {
                struct dpu_plane_state *dpu_pstate = to_dpu_plane_state(pstate);
-               struct drm_rect dst, clip = crtc_rect;

if (IS_ERR_OR_NULL(pstate)) {

                        rc = PTR_ERR(pstate);
@@ -1176,15 +1169,6 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,
                        continue;

dpu_pstate->needs_dirtyfb = needs_dirtyfb;

-
-               dst = drm_plane_state_dest(pstate);
-               if (!drm_rect_intersect(&clip, &dst)) {
-                       DPU_ERROR("invalid vertical/horizontal destination\n");
-                       DPU_ERROR("display: " DRM_RECT_FMT " plane: "
-                                 DRM_RECT_FMT "\n", DRM_RECT_ARG(&crtc_rect),
-                                 DRM_RECT_ARG(&dst));
-                       return -E2BIG;
-               }
        }

atomic_inc(&_dpu_crtc_get_kms(crtc)->bandwidth_ref);