On Tue, 2023-02-14 at 13:38 -0800, Teres Alexis, Alan Previn wrote: > Add MTL's function for ARB session creation using PXP firmware > version 4.3 ABI structure format. > alan:snip > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c > b/drivers/gpu/drm/i915/pxp/intel_pxp.c > index aecc65b5da70..c25e9ff16b57 100644 > --- a/drivers/gpu/drm/i915/pxp/intel_pxp.c > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp.c > @@ -353,8 +353,13 @@ int intel_pxp_start(struct intel_pxp *pxp) > if (!intel_pxp_is_enabled(pxp)) > return -ENODEV; > > - if (wait_for(pxp_component_bound(pxp), 250)) > - return -ENXIO; > + if (HAS_ENGINE(pxp->ctrl_gt, GSC0)) { > + if (wait_for(intel_uc_fw_is_running(&pxp->ctrl_gt->uc.gsc.fw), > 250)) > + return -ENXIO; alan: As per offline conversation with Daniele, at a system level, we should actually need to check if the huc-firmware has been authenticated via the function intel_huc_is_authenticated (as opposed to if gsc fw is running as per this patch). We both realize that huc-authentication is not available yet for MTL on upstream (but that function is already used on ADL/DG2). Eventually when huc-authentication is posted for MTL, this series (hopefully merged by then) would be aligned with that upcoming series. Thus will also make this change in upcoming series.
> + } else { > + if (wait_for(pxp_component_bound(pxp), 250)) > + return -ENXIO;