On 2/27/23 20:38, Rob Clark wrote: > static const struct drm_driver driver = { > - .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_RENDER | > DRIVER_ATOMIC, > + .driver_features = > +#if defined(CONFIG_DRM_VIRTIO_GPU_KMS)
I'd also replace the `#if defined()` with `#if IS_ENABLED()`, for consistency. Maybe won't hurt to expand the commit message a tad, emphasizing the security aspect and telling about the new num_scanouts=0 behaviour. I can change it all while applying, if Gerd is okay with this patch. Othwerise, good to me: Reviewed-by: Dmitry Osipenko <dmitry.osipe...@collabora.com> -- Best regards, Dmitry