On 30.03.2023 23:53, Dmitry Baryshkov wrote: > Theoretically since sm8150 we should be using a single CTL for the > source split case, but since we do not support it for now, fallback to > DPU_CTL_SPLIT_DISPLAY. > > Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dyb...@linaro.org> Konrad > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h > b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h > index 01ef4115ee4d..33f2d53df13b 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h > @@ -42,17 +42,18 @@ static const struct dpu_mdp_cfg sc8280xp_mdp[] = { > }, > }; > > +/* FIXME: get rid of DPU_CTL_SPLIT_DISPLAY in favour of proper ACTIVE_CTL > support */ > static const struct dpu_ctl_cfg sc8280xp_ctl[] = { > { > .name = "ctl_0", .id = CTL_0, > .base = 0x15000, .len = 0x204, > - .features = CTL_SC7280_MASK, > + .features = BIT(DPU_CTL_SPLIT_DISPLAY) | CTL_SC7280_MASK, > .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 9), > }, > { > .name = "ctl_1", .id = CTL_1, > .base = 0x16000, .len = 0x204, > - .features = CTL_SC7280_MASK, > + .features = BIT(DPU_CTL_SPLIT_DISPLAY) | CTL_SC7280_MASK, > .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 10), > }, > {
- [PATCH v3 14/38] drm/msm/dpu: split SC8180X catalog entry... Dmitry Baryshkov
- [PATCH v3 07/38] drm/msm/dpu: split SC8280XP catalog entr... Dmitry Baryshkov
- [PATCH v3 11/38] drm/msm/dpu: split QCM2290 catalog entry... Dmitry Baryshkov
- [PATCH v3 19/38] drm/msm/dpu: duplicate sc7180 catalog en... Dmitry Baryshkov
- [PATCH v3 26/38] drm/msm/dpu: enable DSPP_2/3 for LM_2/3 ... Dmitry Baryshkov
- [PATCH v3 13/38] drm/msm/dpu: split SM8250 catalog entry ... Dmitry Baryshkov
- [PATCH v3 10/38] drm/msm/dpu: split SM6115 catalog entry ... Dmitry Baryshkov
- [PATCH v3 12/38] drm/msm/dpu: split SC7180 catalog entry ... Dmitry Baryshkov
- [PATCH v3 29/38] drm/msm/dpu: deduplicate sc8180x with sm... Dmitry Baryshkov
- [PATCH v3 25/38] drm/msm/dpu: enable DPU_CTL_SPLIT_DISPLA... Dmitry Baryshkov
- Re: [v3, 25/38] drm/msm/dpu: enable DPU_CTL_SPLIT_DI... Konrad Dybcio
- [PATCH v3 15/38] drm/msm/dpu: split SM8150 catalog entry ... Dmitry Baryshkov
- [PATCH v3 35/38] drm/msm/dpu: rename CTL_foo_MASK to cont... Dmitry Baryshkov
- [PATCH v3 16/38] drm/msm/dpu: split MSM8998 catalog entry... Dmitry Baryshkov
- [PATCH v3 24/38] drm/msm/dpu: catalog: add comments regar... Dmitry Baryshkov
- Re: [v3,24/38] drm/msm/dpu: catalog: add comments re... Konrad Dybcio
- [PATCH v3 33/38] drm/msm/dpu: inline IRQ_n_MASK defines Dmitry Baryshkov
- [PATCH v3 28/38] drm/msm/dpu: enable DSPP on sc8180x Dmitry Baryshkov
- Re: [v3,28/38] drm/msm/dpu: enable DSPP on sc8180x Konrad Dybcio
- [PATCH v3 27/38] drm/msm/dpu: drop duplicate vig_sblk ins... Dmitry Baryshkov
- [PATCH v3 20/38] drm/msm/dpu: duplicate sm8150 catalog en... Dmitry Baryshkov