Hi John, > Dan Carpenter pointed out that 'err' was not being set in the case > where the GuC firmware version range check fails. Fix that. > > Note that while this is bug fix for a previous patch (see Fixes tag
is _a_ bug fix. > below). It is an exceedingly low risk bug. The range check is > asserting that the GuC firmware version is within spec. So it should > not be possible to ever have a firmware file that fails this check. If > larger version numbers are required in the future, that would be a > backwards breaking spec change and thus require a major version bump, > in which case an old i915 driver would not load that new version anyway. > > Fixes: 9bbba0667f37 ("drm/i915/guc: Use GuC submission API version number") > Reported-by: Dan Carpenter <erro...@gmail.com> > Signed-off-by: John Harrison <john.c.harri...@intel.com> > Cc: John Harrison <john.c.harri...@intel.com> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> > Cc: Alan Previn <alan.previn.teres.ale...@intel.com> > Cc: Umesh Nerlige Ramappa <umesh.nerlige.rama...@intel.com> > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > Cc: Matthew Brost <matthew.br...@intel.com> > Cc: Andi Shyti <andi.sh...@linux.intel.com> > Cc: Matthew Auld <matthew.a...@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Cc: Lucas De Marchi <lucas.demar...@intel.com> > Cc: Jani Nikula <jani.nik...@intel.com> Reviewed-by: Andi Shyti <andi.sh...@linux.intel.com> Andi