Re: [PATCH 2/2] drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H

[Neil Armstrong]

On 24/05/2023 14:32, Geert Uytterhoeven wrote:

Add support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel.

Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
---
  drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
  1 file changed, 33 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index 5778824dffd47a31..467117c0b2c9d463 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -778,6 +778,36 @@ static const struct drm_display_mode 
ampire_am800480r3tmqwa1h_mode = {
        .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
  };

+static const struct display_timing ampire_am_800480l1tmqw_t00h_timing = {

+       .pixelclock = { 29930000, 33260000, 36590000 },
+       .hactive = { 800, 800, 800 },
+       .hfront_porch = { 1, 40, 168 },
+       .hback_porch = { 88, 88, 88 },
+       .hsync_len = { 1, 128, 128 },
+       .vactive = { 480, 480, 480 },
+       .vfront_porch = { 1, 35, 37 },
+       .vback_porch = { 8, 8, 8 },
+       .vsync_len = { 1, 2, 2 },
+       .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+                DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+                DISPLAY_FLAGS_SYNC_POSEDGE,
+};
+
+static const struct panel_desc ampire_am_800480l1tmqw_t00h = {
+       .timings = &ampire_am_800480l1tmqw_t00h_timing,
+       .num_timings = 1,
+       .bpc = 8,
+       .size = {
+               .width = 111,
+               .height = 67,
+       },
+       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+       .bus_flags = DRM_BUS_FLAG_DE_HIGH |
+                    DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
+                    DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
+       .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
  static const struct panel_desc ampire_am800480r3tmqwa1h = {
        .modes = &ampire_am800480r3tmqwa1h_mode,
        .num_modes = 1,
@@ -3993,6 +4023,9 @@ static const struct of_device_id platform_of_match[] = {
        }, {
                .compatible = "ampire,am-480272h3tmqw-t01h",
                .data = &ampire_am_480272h3tmqw_t01h,
+       }, {
+               .compatible = "ampire,am-800480l1tmqw-t00h",
+               .data = &ampire_am_800480l1tmqw_t00h,
        }, {
                .compatible = "ampire,am800480r3tmqwa1h",
                .data = &ampire_am800480r3tmqwa1h,

Reviewed-by: Neil Armstrong <neil.armstr...@linaro.org>