smatch reports:

drivers/gpu/drm/bridge/tc358768.c:223 tc358768_update_bits() error: 
uninitialized symbol 'orig'.

Fix this by bailing out from tc358768_update_bits() if the
tc358768_read() produces an error.

Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
Reviewed-by: Peter Ujfalusi <peter.ujfal...@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkei...@ideasonboard.com>
---
 drivers/gpu/drm/bridge/tc358768.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/bridge/tc358768.c 
b/drivers/gpu/drm/bridge/tc358768.c
index 819a4b6ec2a0..bc97a837955b 100644
--- a/drivers/gpu/drm/bridge/tc358768.c
+++ b/drivers/gpu/drm/bridge/tc358768.c
@@ -216,6 +216,10 @@ static void tc358768_update_bits(struct tc358768_priv 
*priv, u32 reg, u32 mask,
        u32 tmp, orig;
 
        tc358768_read(priv, reg, &orig);
+
+       if (priv->error)
+               return;
+
        tmp = orig & ~mask;
        tmp |= val & mask;
        if (tmp != orig)

-- 
2.34.1

Reply via email to