On 2023-08-29 14:33, Matthew Wilcox wrote:
On Tue, Aug 29, 2023 at 01:34:22PM -0400, James Zhu wrote:
@@ -1067,7 +1055,7 @@ static void drm_core_exit(void)
unregister_chrdev(DRM_MAJOR, "drm");
debugfs_remove(drm_debugfs_root);
drm_sysfs_destroy();
- idr_destroy(&drm_minors_idr);
[JZ] Should we call xa_destroy instead here?
We could, if we expect the xarray to potentially not be empty.
From what I understand - all minors should be released at this point.
[JZ] In practice, adding destroy here will be better.
Why do you say that?
[JZ] In case, the future, INIT adds something, need DESTROY to free
completely.
