Quoting Jani Nikula (2023-09-01 07:20:34) > The DP CTS test for EDID last block checksum expects the checksum for > the last block, invalid or not. Skip the validity check. > > For the most part (*), the EDIDs returned by drm_get_edid() will be > valid anyway, and there's the CTS workaround to get the checksum for > completely invalid EDIDs. See commit 7948fe12d47a ("drm/msm/dp: return > correct edid checksum after corrupted edid checksum read"). > > This lets us remove one user of drm_edid_block_valid() with hopes the > function can be removed altogether in the future. > > (*) drm_get_edid() ignores checksum errors on CTA extensions. > > Cc: Abhinav Kumar <quic_abhin...@quicinc.com> > Cc: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > Cc: Kuogee Hsieh <khs...@codeaurora.org> > Cc: Marijn Suijten <marijn.suij...@somainline.org> > Cc: Rob Clark <robdcl...@gmail.com> > Cc: Sean Paul <s...@poorly.run> > Cc: Stephen Boyd <swb...@chromium.org> > Cc: linux-arm-...@vger.kernel.org > Cc: freedr...@lists.freedesktop.org > Signed-off-by: Jani Nikula <jani.nik...@intel.com> > ---
Reviewed-by: Stephen Boyd <swb...@chromium.org> > > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c > b/drivers/gpu/drm/msm/dp/dp_panel.c > index 42d52510ffd4..86a8e06c7a60 100644 > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > @@ -289,26 +289,9 @@ int dp_panel_get_modes(struct dp_panel *dp_panel, > > static u8 dp_panel_get_edid_checksum(struct edid *edid) It would be nice to make 'edid' const here in another patch.