The sads returned by drm_edid_to_sad() needs to be freed.

Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
Cc: Guillaume Ranquet <granq...@baylibre.com>
Cc: Bo-Chen Chen <rex-bc.c...@mediatek.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delre...@collabora.com>
Cc: Dmitry Osipenko <dmitry.osipe...@collabora.com>
Cc: Chun-Kuang Hu <chunkuang...@kernel.org>
Cc: Philipp Zabel <p.za...@pengutronix.de>
Cc: Matthias Brugger <matthias....@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media...@lists.infradead.org
Cc: linux-ker...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: <sta...@vger.kernel.org> # v6.1+
Signed-off-by: Jani Nikula <jani.nik...@intel.com>

---

Found another one. UNTESTED.
---
 drivers/gpu/drm/mediatek/mtk_dp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c 
b/drivers/gpu/drm/mediatek/mtk_dp.c
index 8fc6eff68e30..0e285df6577e 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp.c
+++ b/drivers/gpu/drm/mediatek/mtk_dp.c
@@ -2034,7 +2034,6 @@ static struct edid *mtk_dp_get_edid(struct drm_bridge 
*bridge,
        bool enabled = mtk_dp->enabled;
        struct edid *new_edid = NULL;
        struct mtk_dp_audio_cfg *audio_caps = &mtk_dp->info.audio_cur_cfg;
-       struct cea_sad *sads;
 
        if (!enabled) {
                drm_atomic_bridge_chain_pre_enable(bridge, 
connector->state->state);
@@ -2054,7 +2053,11 @@ static struct edid *mtk_dp_get_edid(struct drm_bridge 
*bridge,
        }
 
        if (new_edid) {
+               struct cea_sad *sads;
+
                audio_caps->sad_count = drm_edid_to_sad(new_edid, &sads);
+               kfree(sads);
+
                audio_caps->detect_monitor = drm_detect_monitor_audio(new_edid);
        }
 
-- 
2.39.2

Reply via email to