On 10/10/23 16:57, Huang Rui wrote: > These definitions are used fro qemu, and qemu imports this marco in the > headers to enable gfxstream, venus, cross domain, and drm (native > context) for virtio gpu. So it should add them even kernel doesn't use > this. > > Signed-off-by: Huang Rui <ray.hu...@amd.com> > Reviewed-by: Akihiko Odaki <akihiko.od...@daynix.com> > --- > > Changes V1 -> V2: > - Add all capsets including gfxstream and venus in kernel header (Dmitry > Osipenko) > > Changes V2 -> V3: > - Add missed capsets including cross domain and drm (native context) > (Dmitry Osipenko) > > v1: https://lore.kernel.org/lkml/20230915105918.3763061-1-ray.hu...@amd.com/ > v2: https://lore.kernel.org/lkml/20231010032553.1138036-1-ray.hu...@amd.com/ > > include/uapi/linux/virtio_gpu.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h > index f556fde07b76..240911c8da31 100644 > --- a/include/uapi/linux/virtio_gpu.h > +++ b/include/uapi/linux/virtio_gpu.h > @@ -309,6 +309,10 @@ struct virtio_gpu_cmd_submit { > > #define VIRTIO_GPU_CAPSET_VIRGL 1 > #define VIRTIO_GPU_CAPSET_VIRGL2 2 > +#define VIRTIO_GPU_CAPSET_GFXSTREAM 3
The GFXSTREAM capset isn't correct, it should be GFXSTREAM_VULKAN in accordance to [1] and [2]. There are more capsets for GFXSTREAM. [1] https://github.com/google/crosvm/blob/main/rutabaga_gfx/src/rutabaga_utils.rs#L172 [2] https://patchwork.kernel.org/project/qemu-devel/patch/20231006010835.444-7-gurchetansi...@chromium.org/ -- Best regards, Dmitry
