On Thu, Nov 02, 2023 at 04:47:41PM +0100, Hans de Goede wrote:
> On 11/2/23 16:12, Andy Shevchenko wrote:

...

> > +                   soc_exec_opaque_gpio(connector, gpio_index, 
> > "INT33FF:03", "Panel SE",
> > +                                        gpio_index - 
> > CHV_GPIO_IDX_START_SW, value);
> 
> The "gpio_index - CHV_GPIO_IDX_START_SW" here needs to be "gpio_index - 
> CHV_GPIO_IDX_START_SE".
> 
> Also this patch needs s/soc_exec_opaque_gpio/soc_opaque_gpio_set_value/ to 
> compile ...

Ah, indeed. I looks like I run the test build, but forgot to look into the 
result. :-(

-- 
With Best Regards,
Andy Shevchenko


Reply via email to