On Thu, 30 Nov 2023 16:00:13 +0000, Donald Robson wrote: > This line appears to confuse the compiler and had been noticed previously in > clang-tidy output. There isn't anything fundamentally wrong that I can see. > I suspect that it just looks like a mistake - hence the first note. By making > the second operand an actual bool result, const correctness can be preserved > while silencing the warning. > > >> drivers/gpu/drm/imagination/pvr_device_info.c:230:47: warning: use of > >> logical '&&' with constant operand [-Wconstant-logical-operand] > 230 | } else if (features_size == mapping_max_size && > (mapping_max & 63)) { > | ^ > ~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/imagination/pvr_device_info.c:230:47: note: use '&' for a > bitwise operation > 230 | } else if (features_size == mapping_max_size && > (mapping_max & 63)) { > | ^~ > | & > drivers/gpu/drm/imagination/pvr_device_info.c:230:47: note: remove > constant to silence this warning > 230 | } else if (features_size == mapping_max_size && > (mapping_max & 63)) { > | > ~^~~~~~~~~~~~~~~~~~~~~ > 1 warning generated. > > [...]
Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime