Simplify the error handling in probe function by switching from
dev_err() to dev_err_probe().

Reviewed-by: Daniel Thompson <daniel.thomp...@linaro.org>
Reviewed-by: Javier Martinez Canillas <javi...@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
 drivers/video/backlight/hx8357.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/video/backlight/hx8357.c b/drivers/video/backlight/hx8357.c
index 81d0984e9d8b..70a62755805a 100644
--- a/drivers/video/backlight/hx8357.c
+++ b/drivers/video/backlight/hx8357.c
@@ -579,10 +579,8 @@ static int hx8357_probe(struct spi_device *spi)
                return -ENOMEM;
 
        ret = spi_setup(spi);
-       if (ret < 0) {
-               dev_err(&spi->dev, "SPI setup failed.\n");
-               return ret;
-       }
+       if (ret < 0)
+               return dev_err_probe(dev, ret, "SPI setup failed.\n");
 
        lcd->spi = spi;
 
@@ -617,10 +615,8 @@ static int hx8357_probe(struct spi_device *spi)
        hx8357_lcd_reset(lcdev);
 
        ret = init_fn(lcdev);
-       if (ret) {
-               dev_err(&spi->dev, "Couldn't initialize panel\n");
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "Couldn't initialize panel\n");
 
        dev_info(&spi->dev, "Panel probed\n");
 
-- 
2.43.0.rc1.1.gbec44491f096

Reply via email to