> The two device node references taken during allocation need to be
> dropped when the auxiliary device is freed.
…
> +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.c
…
> @@ -74,6 +75,8 @@ struct device *drm_dp_hpd_bridge_register(struct device
> *parent,
>
> ret = auxiliary_device_init(adev);
> if (ret) {
> + of_node_put(adev->dev.platform_data);
> + of_node_put(adev->dev.of_node);
> ida_free(&drm_aux_hpd_bridge_ida, adev->id);
> kfree(adev);
> return ERR_PTR(ret);
The last two statements are also used in a previous if branch.
https://elixir.bootlin.com/linux/v6.8-rc5/source/drivers/gpu/drm/bridge/aux-hpd-bridge.c#L63
How do you think about to avoid such a bit of duplicate source code
by adding a label here?
Regards,
Markus
