On Wed, Mar 20, 2024 at 11:22:02PM +0000, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > It looks like the main use of strncpy() here is to limit the amount of > bytes printed from hdmi_log() by using a tmp buffer and limiting the > number of bytes copied. Really, we should use the %.<len>s format > qualifier to achieve this. > > Link: > https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings > [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-harden...@vger.kernel.org > Signed-off-by: Justin Stitt <justinst...@google.com>
Reviewed-by: Kees Cook <keesc...@chromium.org> -- Kees Cook
