Re: [PATCH 5/5] drm/vkms: Use drm_crtc_vblank_crtc()

[Maíra Canal]

On 4/8/24 16:06, Ville Syrjala wrote:

From: Ville Syrjälä <ville.syrj...@linux.intel.com>

Replace the open coded drm_crtc_vblank_crtc() with the real
thing.

Cc: Rodrigo Siqueira <rodrigosiqueiram...@gmail.com>
Cc: Melissa Wen <melissa....@gmail.com>
Cc: "Maíra Canal" <mairaca...@riseup.net>
Cc: Haneen Mohammed <hamohammed...@gmail.com>
Cc: Daniel Vetter <dan...@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>

Reviewed-by: Maíra Canal <mca...@igalia.com>

Best Regards,
- Maíra

---
  drivers/gpu/drm/vkms/vkms_crtc.c | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
index 61e500b8c9da..40b4d084e3ce 100644
--- a/drivers/gpu/drm/vkms/vkms_crtc.c
+++ b/drivers/gpu/drm/vkms/vkms_crtc.c
@@ -61,9 +61,7 @@ static enum hrtimer_restart vkms_vblank_simulate(struct 
hrtimer *timer)

static int vkms_enable_vblank(struct drm_crtc *crtc)

  {
-       struct drm_device *dev = crtc->dev;
-       unsigned int pipe = drm_crtc_index(crtc);
-       struct drm_vblank_crtc *vblank = &dev->vblank[pipe];
+       struct drm_vblank_crtc *vblank = drm_crtc_vblank_crtc(crtc);
        struct vkms_output *out = drm_crtc_to_vkms_output(crtc);

drm_calc_timestamping_constants(crtc, &crtc->mode);

@@ -88,10 +86,9 @@ static bool vkms_get_vblank_timestamp(struct drm_crtc *crtc,
                                      bool in_vblank_irq)
  {
        struct drm_device *dev = crtc->dev;
-       unsigned int pipe = crtc->index;
        struct vkms_device *vkmsdev = drm_device_to_vkms_device(dev);
        struct vkms_output *output = &vkmsdev->output;
-       struct drm_vblank_crtc *vblank = &dev->vblank[pipe];
+       struct drm_vblank_crtc *vblank = drm_crtc_vblank_crtc(crtc);

if (!READ_ONCE(vblank->enabled)) {

                *vblank_time = ktime_get();