On 4/6/24 04:21, Dmitry Baryshkov wrote:
On Fri, Apr 05, 2024 at 10:41:30AM +0200, Konrad Dybcio wrote:
Introduce getters for SoC product and feature codes and export them.

Signed-off-by: Konrad Dybcio <konrad.dyb...@linaro.org>
---

[...]


+       /* Ensure the value makes sense */
+       if (raw_code >= SOCINFO_FC_INT_RESERVE)
+               raw_code = SOCINFO_FC_UNKNOWN;

This looks like a c&p from the previous function. Should we be comparing
the raw_code with a SOCINFO_PC_ constant?

Looks like!

Konrad

Reply via email to