On Mon, Apr 22, 2024 at 02:50:09PM +0300, Jani Nikula wrote: > On Mon, 22 Apr 2024, Geert Uytterhoeven <geert+rene...@glider.be> wrote: > > Hi all, > > > > As discussed on IRC with Maxime and Arnd, this series reverts the > > conversion of select to depends for various DRM helpers in series > > "[PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to > > depends on"[1], and various fixes for it. This conversion introduced a > > big usability issue when configuring a kernel and enabling DRM drivers > > that use DRM helper code: as drivers now depend on helpers, the user > > needs to know which helpers to enable, before the driver he is > > interested even becomes visible. The user should not need to know that, > > and drivers should select the helpers they need. > > > > Hence revert back to what we had before, where drivers selected the > > helpers (and any of their dependencies, if they can be met) they need. > > In general, when a symbol selects another symbol, it should just make > > sure the dependencies of the target symbol are met, which may mean > > adding dependencies to the source symbol. > > I still disagree with this, because fundamentally the source symbol > really should not have to care about the dependencies of the target > symbol.
I'd agree with you, but if the driver depends on helpers it becomes ridiculous. So, it seems, we need a different solution for the original problem. > That said, I'm not going to keep arguing against this. Whatever. > > > BR, > Jani. > > > > > > Thanks for applying! > > > > [1] > > https://lore.kernel.org/r/20240327-kms-kconfig-helpers-v3-0-eafee11b8...@kernel.org/ > > > > Geert Uytterhoeven (11): > > Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2" > > Revert "drm/display: Select DRM_KMS_HELPER for DP helpers" > > Revert "drm/bridge: dw-hdmi: Make DRM_DW_HDMI selectable" > > Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies" > > Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on" > > Revert "drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on" > > Revert "drm: Switch DRM_DISPLAY_DP_HELPER to depends on" > > Revert "drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on" > > Revert "drm: Switch DRM_DISPLAY_HELPER to depends on" > > Revert "drm: Make drivers depends on DRM_DW_HDMI" > > Revert "drm/display: Make all helpers visible and switch to depends > > on" > > > > drivers/gpu/drm/Kconfig | 8 +++---- > > drivers/gpu/drm/amd/amdgpu/Kconfig | 12 ++++------ > > drivers/gpu/drm/bridge/Kconfig | 28 +++++++++++----------- > > drivers/gpu/drm/bridge/analogix/Kconfig | 18 +++++++------- > > drivers/gpu/drm/bridge/cadence/Kconfig | 8 +++---- > > drivers/gpu/drm/bridge/imx/Kconfig | 4 ++-- > > drivers/gpu/drm/bridge/synopsys/Kconfig | 6 ++--- > > drivers/gpu/drm/display/Kconfig | 32 ++++++++++--------------- > > drivers/gpu/drm/exynos/Kconfig | 4 ++-- > > drivers/gpu/drm/i915/Kconfig | 8 +++---- > > drivers/gpu/drm/imx/ipuv3/Kconfig | 5 ++-- > > drivers/gpu/drm/ingenic/Kconfig | 2 +- > > drivers/gpu/drm/mediatek/Kconfig | 6 ++--- > > drivers/gpu/drm/meson/Kconfig | 2 +- > > drivers/gpu/drm/msm/Kconfig | 8 +++---- > > drivers/gpu/drm/nouveau/Kconfig | 10 ++++---- > > drivers/gpu/drm/panel/Kconfig | 32 ++++++++++++------------- > > drivers/gpu/drm/radeon/Kconfig | 8 +++---- > > drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +- > > drivers/gpu/drm/rockchip/Kconfig | 10 ++++---- > > drivers/gpu/drm/sun4i/Kconfig | 2 +- > > drivers/gpu/drm/tegra/Kconfig | 8 +++---- > > drivers/gpu/drm/vc4/Kconfig | 10 ++++---- > > drivers/gpu/drm/xe/Kconfig | 13 ++++------ > > drivers/gpu/drm/xlnx/Kconfig | 8 +++---- > > 25 files changed, 116 insertions(+), 138 deletions(-) > > -- > Jani Nikula, Intel -- With best wishes Dmitry
