`dev->of_node` already has a reference to the device_node and calling
of_node_get on it is unnecessary. All conresponding calls to
of_node_put are also removed.

Reviewed-by: Daniel Thompson <daniel.thomp...@linaro.org>
Signed-off-by: Shresth Prasad <shresthpras...@gmail.com>
---
Changes in v3:
    - Remove unnecessary braces

 drivers/video/backlight/sky81452-backlight.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/video/backlight/sky81452-backlight.c 
b/drivers/video/backlight/sky81452-backlight.c
index eb18c6eb0ff0..19f9f84a9fd6 100644
--- a/drivers/video/backlight/sky81452-backlight.c
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -182,7 +182,7 @@ static const struct attribute_group sky81452_bl_attr_group 
= {
 static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
                                                        struct device *dev)
 {
-       struct device_node *np = of_node_get(dev->of_node);
+       struct device_node *np = dev->of_node;
        struct sky81452_bl_platform_data *pdata;
        int num_entry;
        unsigned int sources[6];
@@ -194,10 +194,8 @@ static struct sky81452_bl_platform_data 
*sky81452_bl_parse_dt(
        }
 
        pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
-       if (!pdata) {
-               of_node_put(np);
+       if (!pdata)
                return ERR_PTR(-ENOMEM);
-       }
 
        of_property_read_string(np, "name", &pdata->name);
        pdata->ignore_pwm = of_property_read_bool(np, "skyworks,ignore-pwm");
@@ -217,7 +215,6 @@ static struct sky81452_bl_platform_data 
*sky81452_bl_parse_dt(
                                        num_entry);
                if (ret < 0) {
                        dev_err(dev, "led-sources node is invalid.\n");
-                       of_node_put(np);
                        return ERR_PTR(-EINVAL);
                }
 
@@ -237,7 +234,6 @@ static struct sky81452_bl_platform_data 
*sky81452_bl_parse_dt(
        if (ret < 0)
                pdata->boost_current_limit = 2750;
 
-       of_node_put(np);
        return pdata;
 }
 #else
-- 
2.45.0

Reply via email to