From: Maxime Ripard <max...@cerno.tech>

DLIST generation can get pretty tricky and there's not a lot of debug in
the driver to help. Let's add a few more to track the generated DLIST
size.

Signed-off-by: Maxime Ripard <mrip...@kernel.org>
Signed-off-by: Dave Stevenson <dave.steven...@raspberrypi.com>
---
 drivers/gpu/drm/vc4/vc4_hvs.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c
index 267c9fde7362..189d00fcf4c2 100644
--- a/drivers/gpu/drm/vc4/vc4_hvs.c
+++ b/drivers/gpu/drm/vc4/vc4_hvs.c
@@ -456,11 +456,21 @@ int vc4_hvs_atomic_check(struct drm_crtc *crtc, struct 
drm_atomic_state *state)
        if (hweight32(crtc_state->connector_mask) > 1)
                return -EINVAL;
 
-       drm_atomic_crtc_state_for_each_plane_state(plane, plane_state, 
crtc_state)
-               dlist_count += vc4_plane_dlist_size(plane_state);
+       drm_atomic_crtc_state_for_each_plane_state(plane, plane_state, 
crtc_state) {
+               u32 plane_dlist_count = vc4_plane_dlist_size(plane_state);
+
+               drm_dbg_driver(dev, "[CRTC:%d:%s] Found [PLANE:%d:%s] with 
DLIST size: %u\n",
+                              crtc->base.id, crtc->name,
+                              plane->base.id, plane->name,
+                              plane_dlist_count);
+
+               dlist_count += plane_dlist_count;
+       }
 
        dlist_count++; /* Account for SCALER_CTL0_END. */
 
+       drm_dbg_driver(dev, "[CRTC:%d:%s] Allocating DLIST block with size: 
%u\n",
+                      crtc->base.id, crtc->name, dlist_count);
        spin_lock_irqsave(&vc4->hvs->mm_lock, flags);
        ret = drm_mm_insert_node(&vc4->hvs->dlist_mm, &vc4_state->mm,
                                 dlist_count);
-- 
2.34.1

Reply via email to