On Fri, Jun 21, 2024 at 9:57 PM Matthew Wilcox <wi...@infradead.org> wrote: > > On Fri, Jun 21, 2024 at 10:29:54AM +0800, Yafang Shao wrote: > > +++ b/mm/internal.h > > Why are you putting __kstrndup in a header file when it's only used > in util.c?
I want to make it always inlined. However, it is not recommended to define an inline function in a .c file, right ? > > Also, I think this function is actually __kmemdup_nul(), not > __kstrndup(). > Good suggestion. Will use __kmemdup_nul() instead. -- Regards Yafang