[PATCH v1 5/5] drm/virtio: Add prepare and cleanup routines for imported dmabuf obj

[Vivek Kasireddy]

When an imported dmabuf obj is used as part of an atomic commit, we
need to pin it as part of prepare and unpin it during cleanup of
the associated FB, to make sure that it does not move until the
commit is completed (and also while it is being used on the Host).

Cc: Gerd Hoffmann <kra...@redhat.com>
Signed-off-by: Vivek Kasireddy <vivek.kasire...@intel.com>
---
 drivers/gpu/drm/virtio/virtgpu_plane.c | 71 +++++++++++++++++++++++++-
 1 file changed, 70 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c 
b/drivers/gpu/drm/virtio/virtgpu_plane.c
index a72a2dbda031..5ab0741b67cd 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -25,7 +25,9 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_damage_helper.h>
+#include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_fourcc.h>
+#include <linux/virtio_dma_buf.h>
 
 #include "virtgpu_drv.h"
 
@@ -241,6 +243,48 @@ static void virtio_gpu_primary_plane_update(struct 
drm_plane *plane,
                                  rect.y2 - rect.y1);
 }
 
+static int virtio_gpu_prepare_imported_obj(struct drm_plane *plane,
+                                          struct drm_plane_state *new_state,
+                                          struct drm_gem_object *obj)
+{
+       struct virtio_gpu_device *vgdev = plane->dev->dev_private;
+       struct virtio_gpu_object *bo = gem_to_virtio_gpu_obj(obj);
+       struct dma_buf_attachment *attach = obj->import_attach;
+       struct dma_resv *resv = attach->dmabuf->resv;
+       struct virtio_gpu_mem_entry *ents = NULL;
+       unsigned int nents;
+       int ret;
+
+       dma_resv_lock(resv, NULL);
+
+       ret = dma_buf_pin(attach);
+       if (ret) {
+               dma_resv_unlock(resv);
+               return ret;
+       }
+
+       ret = drm_gem_plane_helper_prepare_fb(plane, new_state);
+       if (ret)
+               goto err;
+
+       if (!bo->sgt) {
+               ret = virtgpu_dma_buf_import_sgt(&ents, &nents,
+                                                bo, attach);
+               if (ret)
+                       goto err;
+
+               virtio_gpu_object_attach(vgdev, bo, ents, nents);
+       }
+
+       dma_resv_unlock(resv);
+       return 0;
+
+err:
+       dma_buf_unpin(attach);
+       dma_resv_unlock(resv);
+       return ret;
+}
+
 static int virtio_gpu_plane_prepare_fb(struct drm_plane *plane,
                                       struct drm_plane_state *new_state)
 {
@@ -248,6 +292,8 @@ static int virtio_gpu_plane_prepare_fb(struct drm_plane 
*plane,
        struct virtio_gpu_device *vgdev = dev->dev_private;
        struct virtio_gpu_framebuffer *vgfb;
        struct virtio_gpu_object *bo;
+       struct drm_gem_object *obj;
+       int ret;
 
        if (!new_state->fb)
                return 0;
@@ -257,7 +303,15 @@ static int virtio_gpu_plane_prepare_fb(struct drm_plane 
*plane,
        if (!bo || (plane->type == DRM_PLANE_TYPE_PRIMARY && !bo->guest_blob))
                return 0;
 
-       if (bo->dumb && (plane->state->fb != new_state->fb)) {
+       obj = new_state->fb->obj[0];
+       if (obj->import_attach) {
+               ret = virtio_gpu_prepare_imported_obj(plane, new_state, obj);
+               if (ret)
+                       return ret;
+       }
+
+       if ((bo->dumb || obj->import_attach) &&
+           (plane->state->fb != new_state->fb)) {
                vgfb->fence = virtio_gpu_fence_alloc(vgdev, 
vgdev->fence_drv.context,
                                                     0);
                if (!vgfb->fence)
@@ -267,10 +321,21 @@ static int virtio_gpu_plane_prepare_fb(struct drm_plane 
*plane,
        return 0;
 }
 
+static void virtio_gpu_cleanup_imported_obj(struct drm_gem_object *obj)
+{
+       struct dma_buf_attachment *attach = obj->import_attach;
+       struct dma_resv *resv = attach->dmabuf->resv;
+
+       dma_resv_lock(resv, NULL);
+       dma_buf_unpin(attach);
+       dma_resv_unlock(resv);
+}
+
 static void virtio_gpu_plane_cleanup_fb(struct drm_plane *plane,
                                        struct drm_plane_state *state)
 {
        struct virtio_gpu_framebuffer *vgfb;
+       struct drm_gem_object *obj;
 
        if (!state->fb)
                return;
@@ -280,6 +345,10 @@ static void virtio_gpu_plane_cleanup_fb(struct drm_plane 
*plane,
                dma_fence_put(&vgfb->fence->f);
                vgfb->fence = NULL;
        }
+
+       obj = state->fb->obj[0];
+       if (obj->import_attach)
+               virtio_gpu_cleanup_imported_obj(obj);
 }
 
 static void virtio_gpu_cursor_plane_update(struct drm_plane *plane,
-- 
2.45.1