[PATCH v3 7/9] drm/tests: Add test for drm_framebuffer_lookup()

[Carlos Eduardo Gallo Filho]

Add two KUnit test cases for the drm_framebuffer_lookup function, one for
the base case, that tests if the lookup finds the correct framebuffer object
and another that tests the lookup for an inexistent framebuffer.

Signed-off-by: Carlos Eduardo Gallo Filho <gcar...@disroot.org>
---
v2:
  - Reorder kunit cases alphabetically.
  - Replace drm_mode_object_add() call to drm_framebuffer_init().
  - Rely on drm_kunit_helper_alloc_device() for mock initialization.
v3:
  - Rename framebuffer variables.
  - Add documentation.
  - Split the lookup for inexistent framebuffer into another test.
  - Call drm_framebuffer_put after lookup on drm_test_framebuffer_lookup test.
---
 drivers/gpu/drm/tests/drm_framebuffer_test.c | 41 ++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c 
b/drivers/gpu/drm/tests/drm_framebuffer_test.c
index 4d0807e1090d..54829e832c5e 100644
--- a/drivers/gpu/drm/tests/drm_framebuffer_test.c
+++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c
@@ -530,10 +530,51 @@ static void drm_test_framebuffer_cleanup(struct kunit 
*test)
        KUNIT_ASSERT_EQ(test, dev->mode_config.num_fb, 0);
 }
 
+/*
+ * Initialize a framebuffer, lookup its id and test if the returned reference
+ * matches.
+ */
+static void drm_test_framebuffer_lookup(struct kunit *test)
+{
+       struct drm_framebuffer_test_priv *priv = test->priv;
+       struct drm_device *dev = &priv->dev;
+       struct drm_format_info format = { };
+       struct drm_framebuffer expected_fb = { .dev = dev, .format = &format };
+       struct drm_framebuffer *returned_fb;
+       uint32_t id = 0;
+       int ret;
+
+       ret = drm_framebuffer_init(dev, &expected_fb, NULL);
+       KUNIT_ASSERT_EQ(test, ret, 0);
+       id = expected_fb.base.id;
+
+       /* Looking for expected_fb */
+       returned_fb = drm_framebuffer_lookup(dev, NULL, id);
+       KUNIT_EXPECT_PTR_EQ(test, returned_fb, &expected_fb);
+       drm_framebuffer_put(returned_fb);
+
+       drm_framebuffer_cleanup(&expected_fb);
+}
+
+/* Try to lookup an id that is not linked to a framebuffer */
+static void drm_test_framebuffer_lookup_inexistent(struct kunit *test)
+{
+       struct drm_framebuffer_test_priv *priv = test->priv;
+       struct drm_device *dev = &priv->dev;
+       struct drm_framebuffer *fb;
+       uint32_t id = 0;
+
+       /* Looking for an inexistent framebuffer */
+       fb = drm_framebuffer_lookup(dev, NULL, id);
+       KUNIT_EXPECT_NULL(test, fb);
+}
+
 static struct kunit_case drm_framebuffer_tests[] = {
        KUNIT_CASE_PARAM(drm_test_framebuffer_check_src_coords, 
check_src_coords_gen_params),
        KUNIT_CASE(drm_test_framebuffer_cleanup),
        KUNIT_CASE_PARAM(drm_test_framebuffer_create, 
drm_framebuffer_create_gen_params),
+       KUNIT_CASE(drm_test_framebuffer_lookup),
+       KUNIT_CASE(drm_test_framebuffer_lookup_inexistent),
        KUNIT_CASE(drm_test_framebuffer_modifiers_not_supported),
        { }
 };
-- 
2.44.2