On 06/14/2010 02:47 PM, Edward Shishkin wrote: > Justin P. Mattock wrote: >> On 06/14/2010 02:05 PM, Edward Shishkin wrote: >>> Justin P. Mattock wrote: >>>> Not sure if this is correct or not. >>>> the below patch gets rid of this warning message >>>> produced by gcc 4.6.0 >>>> >>>> fs/reiserfs/stree.c: In function 'search_by_key': >>>> fs/reiserfs/stree.c:602:6: warning: variable >>>> 'right_neighbor_of_leaf_node' set but not used >>>> >>>> Signed-off-by: Justin P. Mattock <justinmattock at gmail.com> >>> >>> Acked-by: Edward Shishkin <edward.shishkin at gmail.com> >>> >> >> o.k.!! >> what about the whitespace issue? > > Whitespaces should be removed. > I recommend quilt package for managing patches: > "quilt refresh --strip-trailing-whitespace" is your friend.. > > Thanks, > Edward. >
o.k. I resent this.. fixed the whitespace(hopefully) and add your Acked to it. as for quilt I'll have to look into that.. (using a lfs system, so if the sourcecode is easy to deal with(build), then it's a good but if it becomes a nightmare maybe not!!). Justin P. Mattock