From: Hersen Wu <hersenxs...@amd.com>

[ Upstream commit 84723eb6068c50610c5c0893980d230d7afa2105 ]

[Why]
Coverity reports OVERRUN warning. Should abort amdgpu_dm
initialize.

[How]
Return failure to amdgpu_dm_init.

Reviewed-by: Harry Wentland <harry.wentl...@amd.com>
Acked-by: Tom Chung <chiahsuan.ch...@amd.com>
Signed-off-by: Hersen Wu <hersenxs...@amd.com>
Tested-by: Daniel Wheeler <daniel.whee...@amd.com>
Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index e9aac7f7cfdce..9b440b26c6505 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -4543,7 +4543,10 @@ static int amdgpu_dm_initialize_drm_device(struct 
amdgpu_device *adev)
 
        /* There is one primary plane per CRTC */
        primary_planes = dm->dc->caps.max_streams;
-       ASSERT(primary_planes <= AMDGPU_MAX_PLANES);
+       if (primary_planes > AMDGPU_MAX_PLANES) {
+               DRM_ERROR("DM: Plane nums out of 6 planes\n");
+               return -EINVAL;
+       }
 
        /*
         * Initialize primary planes, implicit planes for legacy IOCTLS.
-- 
2.43.0

Reply via email to