[PATCH 19/29] accel/ivpu: Fix reset_engine debugfs file logic

[Jacek Lawrynowicz]

From: Andrzej Kacprowski <andrzej.kacprow...@intel.com>

The current reset_engine implementation unconditionally resets
all engines. Improve implementation to reset only the engine
requested by the user space to allow more granular testing.
Also use DEFINE_DEBUGFS_ATTRIBUTE() to simplify implementation.

Same changes applied to resume_engine debugfs file for consistency.

Signed-off-by: Andrzej Kacprowski <andrzej.kacprow...@intel.com>
Reviewed-by: Jacek Lawrynowicz <jacek.lawrynow...@linux.intel.com>
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynow...@linux.intel.com>
---
 drivers/accel/ivpu/ivpu_debugfs.c | 42 ++++++-------------------------
 1 file changed, 8 insertions(+), 34 deletions(-)

diff --git a/drivers/accel/ivpu/ivpu_debugfs.c 
b/drivers/accel/ivpu/ivpu_debugfs.c
index f788ace8f318f..c2849c12860ed 100644
--- a/drivers/accel/ivpu/ivpu_debugfs.c
+++ b/drivers/accel/ivpu/ivpu_debugfs.c
@@ -340,49 +340,23 @@ static const struct file_operations 
ivpu_force_recovery_fops = {
        .write = ivpu_force_recovery_fn,
 };
 
-static ssize_t
-ivpu_reset_engine_fn(struct file *file, const char __user *user_buf, size_t 
size, loff_t *pos)
+static int ivpu_reset_engine_fn(void *data, u64 val)
 {
-       struct ivpu_device *vdev = file->private_data;
-
-       if (!size)
-               return -EINVAL;
-
-       if (ivpu_jsm_reset_engine(vdev, DRM_IVPU_ENGINE_COMPUTE))
-               return -ENODEV;
-       if (ivpu_jsm_reset_engine(vdev, DRM_IVPU_ENGINE_COPY))
-               return -ENODEV;
+       struct ivpu_device *vdev = (struct ivpu_device *)data;
 
-       return size;
+       return ivpu_jsm_reset_engine(vdev, (u32)val);
 }
 
-static const struct file_operations ivpu_reset_engine_fops = {
-       .owner = THIS_MODULE,
-       .open = simple_open,
-       .write = ivpu_reset_engine_fn,
-};
+DEFINE_DEBUGFS_ATTRIBUTE(ivpu_reset_engine_fops, NULL, ivpu_reset_engine_fn, 
"0x%02llx\n");
 
-static ssize_t
-ivpu_resume_engine_fn(struct file *file, const char __user *user_buf, size_t 
size, loff_t *pos)
+static int ivpu_resume_engine_fn(void *data, u64 val)
 {
-       struct ivpu_device *vdev = file->private_data;
-
-       if (!size)
-               return -EINVAL;
-
-       if (ivpu_jsm_hws_resume_engine(vdev, DRM_IVPU_ENGINE_COMPUTE))
-               return -ENODEV;
-       if (ivpu_jsm_hws_resume_engine(vdev, DRM_IVPU_ENGINE_COPY))
-               return -ENODEV;
+       struct ivpu_device *vdev = (struct ivpu_device *)data;
 
-       return size;
+       return ivpu_jsm_hws_resume_engine(vdev, (u32)val);
 }
 
-static const struct file_operations ivpu_resume_engine_fops = {
-       .owner = THIS_MODULE,
-       .open = simple_open,
-       .write = ivpu_resume_engine_fn,
-};
+DEFINE_DEBUGFS_ATTRIBUTE(ivpu_resume_engine_fops, NULL, ivpu_resume_engine_fn, 
"0x%02llx\n");
 
 static int dct_active_get(void *data, u64 *active_percent)
 {
-- 
2.45.1