Hi

Am 27.09.24 um 21:27 schrieb Felix Kuehling:

On 2024-09-27 10:37, Thomas Zimmermann wrote:
With the next DRM client coming soon (drm_log) and most of DRM's
fbdev emulation consolidated in a few places, it's time to provide
a single place for the clients.

The new module drm_client_lib.ko stores most of the common client
code. It's designed such that drivers can opt into client support,
but the presence of the client module depends on the user's kernel
configuration. Without selected clients, no client module will be
build.

Thomas Zimmermann (5):
   drm/i915: Select DRM_CLIENT_SELECTION
   drm/xe: Select DRM_CLIENT_SELECTION

BTW, we are using drm_client in amdgpu, as well: https://elixir.bootlin.com/linux/v6.11/source/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c#L155

Right. Patch 5 selects DRM_CLIENT in the driver's Kconfig item. This will prove the plain drm_client code without any of the shared implementations (fbdev, log, etc). Unless the user enabled such an implementation, of course.

I've tried several combinations of =y and =m settings of these options and found this to be working well.

Best regards
Thomas


Regards,
  Felix


   drm: Move client-device functions in to drm_client_dev.c
   drm: Select fbdev helpers for modules that require them
   drm: Add client-lib module

  Documentation/gpu/drm-client.rst   |   3 +
  drivers/gpu/drm/Kconfig            |  34 +++++--
  drivers/gpu/drm/Makefile           |  20 +++--
  drivers/gpu/drm/amd/amdgpu/Kconfig |   1 +
  drivers/gpu/drm/drm_client.c       | 122 +------------------------
  drivers/gpu/drm/drm_client_dev.c   | 138 +++++++++++++++++++++++++++++
  drivers/gpu/drm/drm_dumb_buffers.c |   2 +
  drivers/gpu/drm/drm_file.c         |   2 +
  drivers/gpu/drm/drm_framebuffer.c  |   2 +
  drivers/gpu/drm/drm_gem.c          |   2 +
  drivers/gpu/drm/i915/Kconfig       |   1 +
  drivers/gpu/drm/xe/Kconfig         |   1 +
  12 files changed, 196 insertions(+), 132 deletions(-)
  create mode 100644 drivers/gpu/drm/drm_client_dev.c


--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Reply via email to