On Sun, 2010-09-19 at 15:56 +0800, Zhenyu Wang wrote: > On 2010.09.19 08:38:07 +0100, Chris Wilson wrote: > > > > This should be cc'ed for Adam Jackson's attention as well. > > yep, I think I cc-ed ajax in git-send-mail command line...I'll amend the > commit. > > > > +bool drm_detect_monitor_audio(struct edid *edid) > > > > drm_edid_has_monitor_audio()? That is a little more self-descriptive. > > (I also think drm_detect_hdmi_monitor is poorly named.) > > yeah, that looks better. thanks. > > > The last time Adam had a chance to comment on this EDID check, he > > suggested that we cannot rely on has_audio being a reliable indicator of > > the sink's properties. If the EDID has no audio support, then return > > early, otherwise perform the secondary check that extension block contains > > audio data. > > That's also the problem we stuck for quite some time, and until recently > we got reply on this issue. Adam is right, 'basic audio' bit might not be > reliable, so we try to search audio block too, if there's any existence, > we will accept 'basic audio' support as well. Also, would you be able to export drm_find_cea_extension(), I have pending nouveau patches that will require this symbol (to build a HDA ELD from the EDID data for HDMI/DP audio).
With that, you can add my Reviewed-by :) Thanks, Ben. > > Thanks for the review! > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
