[AMD Official Use Only - AMD Internal Distribution Only] Hi Tomi,
Thanks for the patch. > -----Original Message----- > From: Tomi Valkeinen <[email protected]> > Sent: Friday, December 20, 2024 8:30 AM > To: Laurent Pinchart <[email protected]>; Maarten Lankhorst > <[email protected]>; Maxime Ripard <[email protected]>; > Thomas Zimmermann <[email protected]>; David Airlie > <[email protected]>; Simona Vetter <[email protected]>; Jonathan Corbet > <[email protected]>; Simek, Michal <[email protected]>; Sagar, Vishal > <[email protected]> > Cc: [email protected]; [email protected]; linux-arm- > [email protected]; [email protected]; Tomi Valkeinen > <[email protected]> > Subject: [PATCH] drm: xlnx: zynqmp_dpsub: Fix kernel doc > > Fix two kernel doc warnings introduced by the recent DP audio patch: > > - Add a doc line for the new "audio" field > - Remove a reference to zynqmp_dpsub.c from zynqmp.rst, as the .c file > no longer has structured comments > > Fixes: 3ec5c1579305 ("drm: xlnx: zynqmp_dpsub: Add DP audio support") > Closes: https://lore.kernel.org/all/[email protected]/ > Signed-off-by: Tomi Valkeinen <[email protected]> > --- > Documentation/gpu/zynqmp.rst | 2 -- > drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/gpu/zynqmp.rst b/Documentation/gpu/zynqmp.rst > index f57bfa0ad6ec..1a6f9193de22 100644 > --- a/Documentation/gpu/zynqmp.rst > +++ b/Documentation/gpu/zynqmp.rst > @@ -144,6 +144,4 @@ Internals > > .. kernel-doc:: drivers/gpu/drm/xlnx/zynqmp_dp.c > > -.. kernel-doc:: drivers/gpu/drm/xlnx/zynqmp_dpsub.c > - > .. kernel-doc:: drivers/gpu/drm/xlnx/zynqmp_kms.c > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.h > b/drivers/gpu/drm/xlnx/zynqmp_dpsub.h > index 49875529c2a4..d771b8b199e0 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.h > +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.h > @@ -60,6 +60,7 @@ struct zynqmp_dpsub_audio; > * @layers: Video and graphics layers > * @dp: The DisplayPort controller > * @dma_align: DMA alignment constraint (must be a power of 2) > + * @audio: DP audio data > */ > struct zynqmp_dpsub { > struct device *dev; > > --- > base-commit: 74ef9527bd87ead62deabe749a6d867af748d448 > change-id: 20241220-xilinx-dp-audio-doc-fix-0651029616e7 > > Best regards, > -- > Tomi Valkeinen <[email protected]> This looks good to me. Apologies for missing this in my earlier review. I tested this patch with ./scripts/kernel-doc -none drivers/gpu/drm/xlnx/zynqmp_dpsub.c make htmldocs Please feel free to add Reviewed-by: Vishal Sagar <[email protected]> Regards Vishal Sagar
