On Mon, May 26, 2025 at 08:57:35PM +0800, Yongxing Mou wrote: > > > On 2024/12/8 13:42, Dmitry Baryshkov wrote: > > On Thu, Dec 05, 2024 at 08:31:48PM -0800, Abhinav Kumar wrote: > > > Use the dp_panel's stream_id to adjust the offsets for stream 1 > > > which will be used for MST in the dp_catalog. Also add additional > > > register defines for stream 1. > > > > > > Signed-off-by: Abhinav Kumar <quic_abhin...@quicinc.com> > > > --- > > > drivers/gpu/drm/msm/dp/dp_catalog.c | 99 > > > ++++++++++++++++++++++++++++--------- > > > drivers/gpu/drm/msm/dp/dp_catalog.h | 9 ++-- > > > drivers/gpu/drm/msm/dp/dp_ctrl.c | 3 ++ > > > drivers/gpu/drm/msm/dp/dp_panel.c | 2 + > > > drivers/gpu/drm/msm/dp/dp_reg.h | 13 ++++- > > > 5 files changed, 99 insertions(+), 27 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c > > > b/drivers/gpu/drm/msm/dp/dp_panel.c > > > index > > > 172de804dec445cb08ad8e3f058407f483cd6684..662bf02b8b1a5165f927835bef3c11ac091ddce6 > > > 100644 > > > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > > > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > > > @@ -309,7 +309,9 @@ static int msm_dp_panel_setup_vsc_sdp_yuv_420(struct > > > msm_dp_panel *msm_dp_panel) > > > panel = container_of(msm_dp_panel, struct msm_dp_panel_private, > > > msm_dp_panel); > > > catalog = panel->catalog; > > > + > > > msm_dp_mode = &msm_dp_panel->msm_dp_mode; > > > + catalog->stream_id = msm_dp_panel->stream_id; > > > > Why is it a proper place to set catalog->stream_id? It doesn't looks > > like it to me. > Ok, maybe msm_dp_display_set_stream_id is more proper place. Or can we drop > stream_id in catalog totally, and f the stream_id is needed in the catalog > function, pass it as a parameter to the catalog function. just like that: > int msm_dp_ctrl_***(struct msm_dp_ctrl *ctrl, enum msm_dp_stream_id > stream_id,***);
LGTM. -- With best wishes Dmitry
