On 6/17/25 14:49, André Almeida wrote:
> Allow NULL pointers at amdgpu_vm_put_task_info() as it common practice
> for "put" or "free" functions. This avoid an extra check for NULL for
> callers.
>
> Signed-off-by: André Almeida <andrealm...@igalia.com>
Reviewed-by: Christian König <christian.koe...@amd.com>
> ---
> v9: use if (task) instead of if (ZERO_OR_NULL_PTR(task))
> v8: New patch
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 3911c78f8282..de914a39e3f6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2447,7 +2447,8 @@ amdgpu_vm_get_vm_from_pasid(struct amdgpu_device *adev,
> u32 pasid)
> */
> void amdgpu_vm_put_task_info(struct amdgpu_task_info *task_info)
> {
> - kref_put(&task_info->refcount, amdgpu_vm_destroy_task_info);
> + if (task_info)
> + kref_put(&task_info->refcount, amdgpu_vm_destroy_task_info);
> }
>
> /**
