Re: [PATCH 4/4] drm/amdgpu: Allow kfd CRIU with no buffer objects

[Felix Kuehling]

On 2025-06-17 15:45, David Francis wrote:

The kfd CRIU checkpoint ioctl would return an error if trying
to checkpoint a process with no kfd buffer objects.

This is a normal case and should not be an error.

Signed-off-by: David Francis <david.fran...@amd.com>

This patch is

Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>

---
  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index a8cf2d4580cc..9617c696d5b6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -2569,8 +2569,8 @@ static int criu_restore(struct file *filep,
        pr_debug("CRIU restore (num_devices:%u num_bos:%u num_objects:%u 
priv_data_size:%llu)\n",
                 args->num_devices, args->num_bos, args->num_objects, 
args->priv_data_size);

- if (!args->bos || !args->devices || !args->priv_data || !args->priv_data_size ||

-           !args->num_devices || !args->num_bos)
+       if ((args->num_bos > 0 && !args->bos) || !args->devices || 
!args->priv_data ||
+           !args->priv_data_size || !args->num_devices)
                return -EINVAL;

mutex_lock(&p->mutex);