On 16.07.25 11:57, Philipp Stanner wrote:
> On Wed, 2025-07-16 at 09:43 +0000, cao, lin wrote:
>>
>> Hi Philipp,
>>
>>
>> Thank you for the review. I found that this optimization was
>> introduced 9 years ago in commit
>> 777dbd458c89d4ca74a659f85ffb5bc817f29a35 ("drm/amdgpu: drop a dummy
>> wakeup scheduler").
>>
>>
>> Given that the codebase has undergone significant changes over these
>> 9 years. May I ask if I still need to include the Fixes: tag?
>
> Yes. It's a helpful marker to see where the problem comes from, and it
> adds redundancy helping the stable-kernel maintainers in figuring out
> to which kernels to backport it to.
>
> If stable can't apply a patch to a very old stable kernel because the
> code base changed too much, they'll ping us and we might provide a
> dedicated fix.
>
> So like that:
>
> Cc: sta...@vger.kernel.org # v4.6+
> Fixes: 777dbd458c89 ("drm/amdgpu: drop a dummy wakeup scheduler")
FWIW, Fixes: alone is enough for getting backported to stable branches, Cc:
stable is redundant with it.
--
Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer
https://redhat.com \ Libre software enthusiast
