On 7/22/25 11:24 PM, Akhil P Oommen wrote: > On 7/22/2025 7:14 PM, Dmitry Baryshkov wrote: >> On Sun, Jul 20, 2025 at 05:46:09PM +0530, Akhil P Oommen wrote: >>> Set Keepalive votes at appropriate places to block IFPC power collapse >>> until we access all the required registers. This is required during gpu >>> IRQ handling and also during preemption. >>> >>> Signed-off-by: Akhil P Oommen <akhi...@oss.qualcomm.com> >>> ---
[...] >>> +static void set_keepalive_vote(struct msm_gpu *gpu, bool on) >> >> a6xx_set_keepalive_vote() > > static fn! Why do we need prefix here? It's good practice to namespace-prefix your functions, so that you can more easily find them, e.g. in a backtrace. For a prefix, adreno_gmu_ would be even better, as the register doesn't seem to have changed across generations Konrad
