Hi Mark, On Wednesday, 23 July 2025 06:40:13 EDT Mark Brown wrote: > On Tue, Jul 22, 2025 at 03:54:36PM -0400, Detlev Casanova wrote: > > When disconnected, the ELD data cannot be read by the display driver, so > > it just sets the data to 0. > > Please don't put patches for different subsystems into the same series > if there's no dependencies, it just makes dependencies less obvious and > creates hassle merging things.
Yes, sorry, I'll send v3 of this patch separately. > > That makes the ELD parsing code read an ELD version of 0, which is > > invalid. In hdac_hdmi, that is logged with dev_err(), but should be > > logged with dev_info() instead as it is done in sound/core/pcm_drm_eld.c > > > > This avoids printing multiple messages like: > > HDMI: Unknown ELD version 0 > > > > in the kernel log when userspace tries to open the sound device. > > It doesn't, it just lowers the severity of the logs that are printed. > If the goal is to lower the number of messages printed you need to use > a ratelimited print. I see, ratelimited would be good, but it still prints a message about something that is normal behaviour. Maybe this should go further to a dev_dbg(), or is there a specific reason to show this message ? This could also be a special case: - version == 0 -> dev_dbg() - version !=0 && != known_versions -> dev_err() Detlev.
