On Thu, 24 Jul 2025 09:22:44 +0200, Shengjiu Wang wrote: > > The IEC958 subframe format SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE are used > in HDMI and DisplayPort to describe the audio stream, but hardware device > may need to reorder the IEC958 bits for internal transmission, so need > these standard bits definitions for IEC958 subframe format. > > Signed-off-by: Shengjiu Wang <shengjiu.w...@nxp.com> > --- > include/sound/asoundef.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/sound/asoundef.h b/include/sound/asoundef.h > index 09b2c3dffb30..7efd61568636 100644 > --- a/include/sound/asoundef.h > +++ b/include/sound/asoundef.h > @@ -12,6 +12,15 @@ > * Digital audio interface * > * * > > ****************************************************************************/ > +/* IEC958 subframe format */ > +#define IEC958_SUBFRAME_PREAMBLE_MASK (0xf) > +#define IEC958_SUBFRAME_AUXILIARY_MASK (0xf<<4) > +#define IEC958_SUBFRAME_SAMPLE_24_MASK (0xffffff<<4) > +#define IEC958_SUBFRAME_SAMPLE_20_MASK (0xfffff<<8) > +#define IEC958_SUBFRAME_VALIDITY (0x1<<28) > +#define IEC958_SUBFRAME_USER_DATA (0x1<<29) > +#define IEC958_SUBFRAME_CHANNEL_STATUS (0x1<<30) > +#define IEC958_SUBFRAME_PARITY (0x1<<31)
I'd use "U" suffix as it can reach to the MSB. Also, you can put spaces around the operators to align with the standard format, too. I guess you followed to the other code there, but following to the standard coding style would be better. With those addressed, feel free to take my ack for this patch: Reviewed-by: Takashi Iwai <ti...@suse.de> thanks, Takashi
