Hi,
On Mon, Jul 28, 2025 at 10:44 PM Brigham Campbell
<m...@brighamcampbell.com> wrote:
>
> Fix bug in nt35560_set_brightness() which causes the function to
> erroneously report an error. mipi_dsi_dcs_write() returns either a
> negative value when an error occurred or a positive number of bytes
> written when no error occurred. The buggy code reports an error under
> either condition.
>
> Fixes: 7835ed6a9e86 ("drm/panel-sony-acx424akp: Modernize backlight handling")
I think your Fixes tag is wrong, actually. I think it needs to be:
Fixes: 8152c2bfd780 ("drm/panel: Add driver for Sony ACX424AKP panel")
Even though that commit that you pointed at moved the code around, I
believe the code has been wrong since the start of the driver.
Other than that:
Reviewed-by: Douglas Anderson <diand...@chromium.org>
