Thu, Aug 21, 2025 at 03:30:30PM +0300, Dan Carpenter wrote:
> The devm_drm_bridge_alloc() function returns error pointers, it never
> returns NULL. Fix the checking to match.
>
> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
> Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
Hi,
This change already sent by Ying Liu:
https://lore.kernel.org/all/20250806084121.510207-1-victor....@nxp.com/
Regards,
Joseph
> ---
> drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c
> b/drivers/gpu/drm/bridge/waveshare-dsi.c
> index 01c70e7d3d3b..43f4e7412d72 100644
> --- a/drivers/gpu/drm/bridge/waveshare-dsi.c
> +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
> @@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
> int ret;
>
> ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge,
> &ws_bridge_bridge_funcs);
> - if (!ws)
> - return -ENOMEM;
> + if (IS_ERR(ws))
> + return PTR_ERR(ws);
>
> ws->dev = dev;
>
> --
> 2.47.2
>
