Re: [PATCH] gpu: host1x: use dev_err_probe() in probe path

[Mikko Perttunen]

On Monday, July 28, 2025 9:15 AM Akhilesh Patil wrote:
> Use dev_err_probe() helper as recommended by core driver model in
> drivers/base/core.c to handle deferred probe error. Improve code
> consistency and debuggability using standard helper.
> 
> Signed-off-by: Akhilesh Patil <akhil...@ee.iitb.ac.in>
> ---
>  drivers/gpu/host1x/dev.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
> index 1f93e5e276c0..e6f3cbeb9ae5 100644
> --- a/drivers/gpu/host1x/dev.c
> +++ b/drivers/gpu/host1x/dev.c
> @@ -587,11 +587,7 @@ static int host1x_probe(struct platform_device *pdev)
>       host->clk = devm_clk_get(&pdev->dev, NULL);
>       if (IS_ERR(host->clk)) {
>               err = PTR_ERR(host->clk);
> -
> -             if (err != -EPROBE_DEFER)
> -                     dev_err(&pdev->dev, "failed to get clock: %d\n", 
err);
> -
> -             return err;
> +             return dev_err_probe(&pdev->dev, err, "failed to get clock: 
%d\n", err);

AIUI, dev_err_probe already prints err, so we don't need to repeat it in the 
message. With that, PTR_ERR(host->clk) can also be inlined into the 
dev_err_probe call.

Cheers,
Mikko

>       }
> 
>       err = host1x_get_resets(host);