On Thu, Sep 11, 2025 at 05:26:25PM +0200, Cyrille Pitchen wrote: > The Microchip GFX2D GPU is embedded in the SAM9X60 and SAM9X7 SoC family. > Describe how the GFX2D GPU is integrated in these SoCs, including > register space, interrupt and clock. > > Signed-off-by: Cyrille Pitchen <[email protected]> > --- > .../devicetree/bindings/gpu/microchip,gfx2d.yaml | 53 > ++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/microchip,gfx2d.yaml > b/Documentation/devicetree/bindings/gpu/microchip,gfx2d.yaml > new file mode 100644 > index > 0000000000000000000000000000000000000000..e416e13bc6627a0fef3c70625a6a3e2d91636ffc > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/microchip,gfx2d.yaml
Filename matching a compatible please. > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpu/microchip,gfx2d.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip GFX2D GPU > + > +maintainers: > + - Cyrille Pitchen <[email protected]> > + > +properties: > + compatible: > + enum: > + - microchip,sam9x60-gfx2d > + - microchip,sam9x7-gfx2d > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + const: periph_clk > + maxItems: 1 Why do you need clock-names if you only have one clock? If there's a reason to keep it, drop the _clk - it's redundant. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/clock/at91.h> > + gfx2d@f0018000 { "gfx2d" is not a generic node name, I assume this should actually be "gpu"? Cheers, Conor. > + compatible = "microchip,sam9x60-gfx2d"; > + reg = <0xf0018000 0x4000>; > + interrupts = <36 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 36>; > + clock-names = "periph_clk"; > + }; > + > +... > > -- > 2.48.1 > >
signature.asc
Description: PGP signature
