On Thu, Sep 11, 2025 at 03:28:48PM +0300, Abel Vesa wrote:
> +
> + mdp_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-200000000 {
> + opp-hz = /bits/ 64 <200000000>;
> + required-opps = <&rpmhpd_opp_low_svs>;
> + };
> +
> + opp-325000000 {
> + opp-hz = /bits/ 64 <325000000>;
> + required-opps = <&rpmhpd_opp_svs>;
> + };
> +
> + opp-375000000 {
> + opp-hz = /bits/ 64 <375000000>;
> + required-opps = <&rpmhpd_opp_svs_l1>;
> + };
> +
> + opp-514000000 {
> + opp-hz = /bits/ 64 <514000000>;
> + required-opps = <&rpmhpd_opp_nom>;
> + };
> + };
> + };
> +
> + displayport-controller@ae90000 {
> + compatible = "qcom,glymur-dp";
> + reg = <0 0xae90000 0 0x200>,
> + <0 0xae90200 0 0x200>,
> + <0 0xae90400 0 0x600>,
> + <0 0xae91000 0 0x400>,
> + <0 0xae91400 0 0x400>;
> +
> + interrupt-parent = <&mdss>;
> + interrupts = <12>;
> +
> + clocks = <&dispcc_mdss_ahb_clk>,
> + <&dispcc_dptx0_aux_clk>,
> + <&dispcc_dptx0_link_clk>,
> + <&dispcc_dptx0_link_intf_clk>,
> + <&dispcc_dptx0_pixel0_clk>;
Mis-aligned entries.
> + clock-names = "core_iface", "core_aux",
> + "ctrl_link",
> + "ctrl_link_iface",
> + "stream_pixel";
Same here and in other places.
> +
> + assigned-clocks = <&dispcc_mdss_dptx0_link_clk_src>,
> + <&dispcc_mdss_dptx0_pixel0_clk_src>;
> + assigned-clock-parents = <&usb_1_ss0_qmpphy
> QMP_USB43DP_DP_LINK_CLK>,
> + <&usb_1_ss0_qmpphy QMP_USB43DP_DP_VCO_DIV_CLK>;
> +
> + operating-points-v2 = <&mdss_dp0_opp_table>;
> +
> + power-domains = <&rpmhpd RPMHPD_MMCX>;
> +
> + phys = <&usb_1_ss0_qmpphy QMP_USB43DP_DP_PHY>;
> + phy-names = "dp";
> +
> + #sound-dai-cells = <0>;
> +
> + ports {
> + #address-cells = <1>;
Mixed up indentation, keep 4 spaces.
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + mdss_dp0_in: endpoint {
> + remote-endpoint = <&mdss_intf0_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + mdss_dp0_out: endpoint {
> + };
> + };
> + };
Best regards,
Krzysztof
