On Thu, Sep 11, 2025 at 10:55:03PM +0800, Xiangxu Yin wrote:
> Move reset configuration to be managed via qmp_phy_cfg instead of
> hardcoded lists. This enables per-PHY customization and simplifies
> initialization logic for USB-only and USB/DP switchable PHYs.
> 
> Signed-off-by: Xiangxu Yin <[email protected]>
> ---
>  drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 56 
> ++++++++++++++++++--------------
>  1 file changed, 31 insertions(+), 25 deletions(-)
> 
> @@ -1147,11 +1159,6 @@ static int qmp_usbc_parse_dt_legacy(struct qmp_usbc 
> *qmp, struct device_node *np
>  
>       qmp->num_clks = ret;
>  
> -     ret = qmp_usbc_reset_init(qmp, usb3phy_legacy_reset_l,
> -                              ARRAY_SIZE(usb3phy_legacy_reset_l));

You can not do this, it will break compatibility with the historical
DTS. Legacy code should continue using the old list of resets.

> -     if (ret)
> -             return ret;
> -
>       return 0;
>  }
>  

-- 
With best wishes
Dmitry

Reply via email to